WAIT: Show recipient job title, agency, and city/state on the recipients page#1821
Open
maebeale wants to merge 2 commits into
Open
WAIT: Show recipient job title, agency, and city/state on the recipients page#1821maebeale wants to merge 2 commits into
maebeale wants to merge 2 commits into
Conversation
The recipients page now drives each recipient's affiliation line(s) off the org(s) connected to their registration rather than all of their affiliations. For each connected org it shows the registrant's active job title with the agency name and city/state; absent a job affiliation it falls back to a title-less line when they facilitate at that org and the org is active or pending. Multiple connected orgs render multiple lines. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
commented
Jun 22, 2026
| end | ||
|
|
||
| # Org statuses that still warrant showing a facilitator-only fallback line. | ||
| FALLBACK_FACILITATOR_STATUSES = %w[Active Pending].freeze |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: "active_or_pending" is read as the organization's status (Active/Pending) — the only Active/Pending concept in the schema (affiliations have no pending state). The facilitator fallback shows only when the registrant facilitates at the org and the org is Active/Pending.
Lead with the job title, then the agency name and its city/state, per the preferred display order. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
changed the title
Collaborator
Author
|
maebeale
marked this pull request as ready for review
June 22, 2026 01:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REVIEW NEEDED: 📖 Read — light-logic: a new EventDashboard method + a view swap, no migrations or data changes
Each scholarship recipient's affiliation line(s) on the recipients page now derive from the org(s) connected to their registration (the snapshot taken at registration plus any an admin linked later), not from all of their affiliations.
Organization#program_location).Logic lives in
EventDashboard#recipient_affiliations_by_registrant(preloads org addresses + status to avoid N+1); the view just renders the rows.Why
The old line iterated every non-facilitator affiliation active at the event date. Anchoring on the registration's orgs keeps what's shown tied to what the registration is actually about, and adds the agency location + a facilitator fallback.